Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/storagegateway_gateway - add missing smb_active_directory_settings arguments + validations. #16472

Merged
merged 14 commits into from
Dec 2, 2020
Merged

r/storagegateway_gateway - add missing smb_active_directory_settings arguments + validations. #16472

merged 14 commits into from
Dec 2, 2020

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_storagegateway_gateway - add `timeout_in_seconds`, `organizational_unit`, `domain_controllers` arguments for `smb_active_directory_settings` block.
resource_aws_storagegateway_gateway - add `smb_active_directory_settings. active_directory_status`, `ec2_instance_id`, `endpoint_type`, `host_environment`, and `gateway_network_interface` attributes.
resource_aws_storagegateway_gateway - add plan time validations for `smb_guest_password`, `smb_active_directory_settings. username`, `smb_active_directory_settings. password`, `smb_active_directory_settings. domain_name`, `gateway_timezone`, and `gateway_name`.
resource_aws_storagegateway_gateway - add support for `medium_changer_type`  value `medium_changer_type`.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSStorageGatewayGateway_'
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (265.38s)
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthAll (457.53s)
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthUpload (457.54s)
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthDownload (468.90s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (360.21s)
--- PASS: TestAccAWSStorageGatewayGateway_disappears (278.12s)
--- PASS: TestAccAWSStorageGatewayGateway_SMBSecurityStrategy (316.96s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbGuestPassword (358.11s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint (360.93s)
--- PASS: TestAccAWSStorageGatewayGateway_tags (421.61s)
--- PASS: TestAccAWSStorageGatewayGateway_CloudWatchLogs (312.24s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout (858.86s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings (871.12s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (369.13s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (243.59s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (271.97s)
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (312.99s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner November 27, 2020 21:46
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/storagegateway Issues and PRs that pertain to the storagegateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 27, 2020
@DrFaust92 DrFaust92 changed the title r/storagegateway_gateway - add missing smb_active_directory_settings argument + validations. r/storagegateway_gateway - add missing smb_active_directory_settings arguments + validations. Nov 27, 2020
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 27, 2020
ewbankkit
ewbankkit approved these changes Nov 29, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayGateway_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSStorageGatewayGateway_ -timeout 120m
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Stored
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Stored
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Vtl
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Vtl
=== RUN   TestAccAWSStorageGatewayGateway_tags
=== PAUSE TestAccAWSStorageGatewayGateway_tags
=== RUN   TestAccAWSStorageGatewayGateway_GatewayName
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayName
=== RUN   TestAccAWSStorageGatewayGateway_CloudWatchLogs
=== PAUSE TestAccAWSStorageGatewayGateway_CloudWatchLogs
=== RUN   TestAccAWSStorageGatewayGateway_GatewayTimezone
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayTimezone
=== RUN   TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
=== RUN   TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
=== PAUSE TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
=== RUN   TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
=== PAUSE TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
=== RUN   TestAccAWSStorageGatewayGateway_SmbGuestPassword
=== PAUSE TestAccAWSStorageGatewayGateway_SmbGuestPassword
=== RUN   TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
=== PAUSE TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
=== RUN   TestAccAWSStorageGatewayGateway_disappears
=== PAUSE TestAccAWSStorageGatewayGateway_disappears
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthUpload
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthUpload
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthDownload
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthDownload
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthAll
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthAll
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== CONT  TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (235.86s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
--- PASS: TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint (346.22s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayTimezone
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (240.02s)
=== CONT  TestAccAWSStorageGatewayGateway_CloudWatchLogs
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings (906.61s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayName
--- PASS: TestAccAWSStorageGatewayGateway_CloudWatchLogs (200.75s)
=== CONT  TestAccAWSStorageGatewayGateway_tags
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (274.00s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Vtl
--- PASS: TestAccAWSStorageGatewayGateway_tags (278.14s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Stored
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (235.54s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_FileS3
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (214.21s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthUpload
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (234.89s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthAll
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthUpload (268.20s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthDownload
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthAll (292.91s)
=== CONT  TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
=== CONT  TestAccAWSStorageGatewayGateway_disappears
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthDownload (305.92s)
=== CONT  TestAccAWSStorageGatewayGateway_SmbGuestPassword
--- PASS: TestAccAWSStorageGatewayGateway_SMBSecurityStrategy (233.29s)
--- PASS: TestAccAWSStorageGatewayGateway_disappears (219.86s)
=== CONT  TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
--- PASS: TestAccAWSStorageGatewayGateway_SmbGuestPassword (220.10s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout (811.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3120.961s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayGateway_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSStorageGatewayGateway_ -timeout 120m
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Stored
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Stored
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Vtl
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Vtl
=== RUN   TestAccAWSStorageGatewayGateway_tags
=== PAUSE TestAccAWSStorageGatewayGateway_tags
=== RUN   TestAccAWSStorageGatewayGateway_GatewayName
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayName
=== RUN   TestAccAWSStorageGatewayGateway_CloudWatchLogs
=== PAUSE TestAccAWSStorageGatewayGateway_CloudWatchLogs
=== RUN   TestAccAWSStorageGatewayGateway_GatewayTimezone
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayTimezone
=== RUN   TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
=== RUN   TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
=== PAUSE TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
=== RUN   TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
=== PAUSE TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
=== RUN   TestAccAWSStorageGatewayGateway_SmbGuestPassword
=== PAUSE TestAccAWSStorageGatewayGateway_SmbGuestPassword
=== RUN   TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
=== PAUSE TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
=== RUN   TestAccAWSStorageGatewayGateway_disappears
=== PAUSE TestAccAWSStorageGatewayGateway_disappears
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthUpload
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthUpload
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthDownload
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthDownload
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthAll
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthAll
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== CONT  TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (208.89s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthAll
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthAll (273.32s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthDownload
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings (657.51s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthUpload
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthDownload (217.16s)
=== CONT  TestAccAWSStorageGatewayGateway_disappears
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthUpload (231.02s)
=== CONT  TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
--- PASS: TestAccAWSStorageGatewayGateway_disappears (202.49s)
=== CONT  TestAccAWSStorageGatewayGateway_SmbGuestPassword
--- PASS: TestAccAWSStorageGatewayGateway_SMBSecurityStrategy (203.25s)
=== CONT  TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
--- PASS: TestAccAWSStorageGatewayGateway_SmbGuestPassword (250.05s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayName
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (204.87s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
--- PASS: TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint (279.71s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayTimezone
--- PASS: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout (773.72s)
=== CONT  TestAccAWSStorageGatewayGateway_CloudWatchLogs
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (236.27s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Vtl
--- PASS: TestAccAWSStorageGatewayGateway_CloudWatchLogs (203.90s)
=== CONT  TestAccAWSStorageGatewayGateway_tags
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (177.79s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Stored
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (214.65s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_FileS3
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (197.38s) 
--- PASS: TestAccAWSStorageGatewayGateway_tags (257.25s)

Verified Acceptance Tests in GovCloud (us-gov-west-1)

Note that failures here are a known issue and are tracked here: #16172

make testacc TEST=./aws TESTARGS='-run=TestAccAWSStorageGatewayGateway_' ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 2 -run=TestAccAWSStorageGatewayGateway_ -timeout 120m
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_FileS3
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Stored
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Stored
=== RUN   TestAccAWSStorageGatewayGateway_GatewayType_Vtl
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayType_Vtl
=== RUN   TestAccAWSStorageGatewayGateway_tags
=== PAUSE TestAccAWSStorageGatewayGateway_tags
=== RUN   TestAccAWSStorageGatewayGateway_GatewayName
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayName
=== RUN   TestAccAWSStorageGatewayGateway_CloudWatchLogs
=== PAUSE TestAccAWSStorageGatewayGateway_CloudWatchLogs
=== RUN   TestAccAWSStorageGatewayGateway_GatewayTimezone
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayTimezone
=== RUN   TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
=== PAUSE TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
=== RUN   TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
=== PAUSE TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
=== RUN   TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
=== PAUSE TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
=== RUN   TestAccAWSStorageGatewayGateway_SmbGuestPassword
=== PAUSE TestAccAWSStorageGatewayGateway_SmbGuestPassword
=== RUN   TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
=== PAUSE TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
=== RUN   TestAccAWSStorageGatewayGateway_disappears
=== PAUSE TestAccAWSStorageGatewayGateway_disappears
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthUpload
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthUpload
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthDownload
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthDownload
=== RUN   TestAccAWSStorageGatewayGateway_bandwidthAll
=== PAUSE TestAccAWSStorageGatewayGateway_bandwidthAll
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Cached
=== CONT  TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings
    resource_aws_storagegateway_gateway_test.go:400: Step 1/2 error: Error running apply: 2020/12/01 13:34:47 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0

        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 12b47249-efe8-4467-b8f7-c82d971edbb2 : RequestId: 12b47249-efe8-4467-b8f7-c82d971edbb2
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "12b47249-efe8-4467-b8f7-c82d971edbb2"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 12b47249-efe8-4467-b8f7-c82d971edbb2 : RequestId: 12b47249-efe8-4467-b8f7-c82d971edbb2",
          RequestId: "12b47249-efe8-4467-b8f7-c82d971edbb2"
        }


--- FAIL: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings (19.86s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayName
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Cached (220.26s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint
--- PASS: TestAccAWSStorageGatewayGateway_GatewayName (239.93s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayTimezone
--- PASS: TestAccAWSStorageGatewayGateway_GatewayTimezone (188.78s)
=== CONT  TestAccAWSStorageGatewayGateway_CloudWatchLogs
--- PASS: TestAccAWSStorageGatewayGateway_GatewayVpcEndpoint (251.76s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthUpload
--- PASS: TestAccAWSStorageGatewayGateway_CloudWatchLogs (169.69s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthAll
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthUpload (222.56s)
=== CONT  TestAccAWSStorageGatewayGateway_bandwidthDownload
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthAll (253.21s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Vtl
--- PASS: TestAccAWSStorageGatewayGateway_bandwidthDownload (241.13s)
=== CONT  TestAccAWSStorageGatewayGateway_tags
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Vtl (202.43s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_Stored
--- PASS: TestAccAWSStorageGatewayGateway_tags (260.26s)
=== CONT  TestAccAWSStorageGatewayGateway_SMBSecurityStrategy
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_Stored (211.64s)
=== CONT  TestAccAWSStorageGatewayGateway_disappears
--- PASS: TestAccAWSStorageGatewayGateway_SMBSecurityStrategy (224.80s)
=== CONT  TestAccAWSStorageGatewayGateway_SmbGuestPassword
--- PASS: TestAccAWSStorageGatewayGateway_disappears (188.79s)
=== CONT  TestAccAWSStorageGatewayGateway_GatewayType_FileS3
--- PASS: TestAccAWSStorageGatewayGateway_GatewayType_FileS3 (167.93s)
=== CONT  TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout
    resource_aws_storagegateway_gateway_test.go:430: Step 1/2 error: Error running apply: 2020/12/01 14:02:08 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0

        Error: ClientException: Simple AD directory creation is currently not supported in this region. : RequestId: 57ddbb70-4236-45da-af46-e0ef24f80c02 : RequestId: 57ddbb70-4236-45da-af46-e0ef24f80c02
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "57ddbb70-4236-45da-af46-e0ef24f80c02"
          },
          Message_: "Simple AD directory creation is currently not supported in this region. : RequestId: 57ddbb70-4236-45da-af46-e0ef24f80c02 : RequestId: 57ddbb70-4236-45da-af46-e0ef24f80c02",
          RequestId: "57ddbb70-4236-45da-af46-e0ef24f80c02"
        }


--- FAIL: TestAccAWSStorageGatewayGateway_SmbActiveDirectorySettings_timeout (18.73s)
--- PASS: TestAccAWSStorageGatewayGateway_SmbGuestPassword (310.91s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	1733.452s
FAIL
make: *** [testacc] Error 1

@breathingdust breathingdust added this to the v3.20.0 milestone Dec 2, 2020
@breathingdust breathingdust merged commit 7848157 into hashicorp:master Dec 2, 2020
breathingdust added a commit that referenced this pull request Dec 2, 2020
@breathingdust
Update CHANGELOG.md for #16472
d7fb1a4
@ghost
Copy link

ghost commented Dec 3, 2020

This has been released in version 3.20.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 2, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2021
@DrFaust92 DrFaust92 deleted the r/storagegateway_gateway_refactor branch April 15, 2021 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/storagegateway Issues and PRs that pertain to the storagegateway service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @breathingdust @ewbankkit